Invidious

For those who don't understand code. I have no idea what the context is, but basically, this code handles charged shots, I presume activated in a batch that sets off all available shots. The code gathers a list of all available marbles, then one by one fires them based on how much they have managed to charge up shots. The problem is, in C#, there is no handler for integer overflows as there is in a language like Python. So here he has called the value, that is presumably stored as an undetermined type value (ie a var) and executed it as a 32bit integer, which has a max value of 2.1 billion or so. Doing this would make the value fire as infinite, which would not properly apply math values and probably just throw an error on his background debug console. Either that or it would only read the first 32 bits of data, which most likely are basically 0, although I'm pretty sure C# shouldn't do this. Basically, the bug is the (int) in the at the end. Theres multiple solutions ofc for this, the easiest being just calling the number as a long, which is a 64 bit integer, which has a max value of 9,223,372,036,854,775,807, and I imagine if 9 billion was higher than expected, the long should be virtually impossible to reach.

10 months ago (edited) | 25